Re: [Xen-devel] [PATCH] libxc: make unlock_page return error

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 17:01 +0100 on 19 Aug (1282237291), Ian Campbell wrote:
> > > Given that this patch was only for debugging purposes for an issue which
> > > is now resolved is there any need?
> > 
> > The need I see for now is a future regression.
> 
> But if nothing checks the return value what use is it?
> 
> If it's just for your debug patch you can always apply this same thing
> as part of that debug patch, there's no need for it to be upstream.

+1.  Any future bug-hunter who needs this value can trivially add it,
and as it stands it's just increasing the number of unchecked return
values in the codebase.

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel