[Xen-devel] Re: xen_hvm_callback_vector

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Sat, 2010-08-28 at 22:40 +0100, Jeremy Fitzhardinge wrote:
> On 08/28/2010 11:19 AM, Ian Campbell wrote:
> > xen_evtchn_do_upcall is used for the callback vector interrupt injection
> > (and regular PV obviously).
> >
> > xen_hvm_evtchn_do_upcall is used by the old-style PCI IRQ injection
> > route in platform-pci.c if the callback vector is not available.
> >
> > So entry_64.S should be using xen_evtchn_do_upcall.
> >
> > Also, I think smp_xen_hvm_callback_vector is simply a redundant
> > duplicate of xen_evtchn_do_upcall which could be removed.
> 
> smp_xen_hvm_callback_vector is just missing,

It's in drivers/xen/events.c, in the stable-2.6.32.x branch at least.

> so I think it should be
> using BUILD_INTERRUPT3 with the third arg being xen_evtchn_do_upcall.

I agree.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel