[Xen-devel] Re: xen_hvm_callback_vector

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Sat, 28 Aug 2010, Jeremy Fitzhardinge wrote:
>  On 08/28/2010 11:19 AM, Ian Campbell wrote:
> > xen_evtchn_do_upcall is used for the callback vector interrupt injection
> > (and regular PV obviously).
> >
> > xen_hvm_evtchn_do_upcall is used by the old-style PCI IRQ injection
> > route in platform-pci.c if the callback vector is not available.
> >
> > So entry_64.S should be using xen_evtchn_do_upcall.
> >
> > Also, I think smp_xen_hvm_callback_vector is simply a redundant
> > duplicate of xen_evtchn_do_upcall which could be removed.

That's true, in fact I removed it in my tree.
It should be removed in the upstream version too, I just forgot to
send an update to Jeremy for the stable tree.

In my tree in entry_64 I have

apicinterrupt XEN_HVM_EVTCHN_CALLBACK \
        xen_hvm_callback_vector xen_evtchn_do_upcall

where xen_evtchn_do_upcall is the same callback that PV guests use and
smp_xen_hvm_callback_vector has been removed from drivers/xen/events.c
too.


> 
> smp_xen_hvm_callback_vector is just missing, so I think it should be
> using BUILD_INTERRUPT3 with the third arg being xen_evtchn_do_upcall.

BUILD_INTERRUPT3 is an x86_32 only MACRO, that's why I am using
apicinterrupt instead.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel