Re: [Xen-devel] Problem compiling Kernel 2.6.18 - netfront.c

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2010-10-12 at 09:56 +0100, Carsten Schiers wrote:
> 
> 
> Hi,
> 
> do I have a problem with my .config or does changeset 578f036ec7dd miss some 
> declaration?
> 
>  CC      drivers/xen/netfront/netfront.o                                      
>  
> drivers/xen/netfront/netfront.c: In function 'netfront_get_drvinfo':          
>   
> drivers/xen/netfront/netfront.c:1779: warning: implicit declaration of 
> function 
> 'dev_name'                                                                    
>   
> drivers/xen/netfront/netfront.c:1779: error: 'struct net_device' has no 
> member n
> amed 'dev'                                                                    
>   
> drivers/xen/netfront/netfront.c:1779: warning: passing argument 2 of 'strcpy' 
> ma
> kes pointer from integer without a cast                                       
>   
> make[3]: *** [drivers/xen/netfront/netfront.o] Fehler 1                       
>   
> make[2]: *** [drivers/xen/netfront] Fehler 2                                  
>   
> make[1]: *** [drivers/xen] Fehler 2                                           
>   
> make: *** [drivers] Fehler 2 

Looks like 2.6.18 sysfs differs from whichever kernel the patch was
originally written against.

Untested patch based on the netback get_drvinfo method from 2.6.18
below, does it work for you?

diff -r 578f036ec7dd drivers/xen/netfront/netfront.c
--- a/drivers/xen/netfront/netfront.c   Mon Oct 11 10:25:55 2010 +0100
+++ b/drivers/xen/netfront/netfront.c   Tue Oct 12 10:19:15 2010 +0100
@@ -1776,7 +1776,7 @@ static void netfront_get_drvinfo(struct 
                                 struct ethtool_drvinfo *info)
 {
        strcpy(info->driver, "netfront");
-       strcpy(info->bus_info, dev_name(dev->dev.parent));
+       strcpy(info->bus_info, dev->class_dev.dev->bus_id);
 }
 
 static int network_connect(struct net_device *dev)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel