[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH V3 0/6] firmware changes as part of QEMU/Xen merge.
On 29/10/2010 14:11, "Pasi Kärkkäinen" <pasik@xxxxxx> wrote: >> Xen will register the old ioport by default and switch to the new ioport if >> the >> HVM_PARAM_ACPI_NEW_IOPORT is set. So, this series come with a new function, >> unregister_io_handler, and a new HVM_PARAM. >> > > Should it be called something else than HVM_PARAM_ACPI_NEW_IOPORT ? > After a couple of years "NEW" might not make much sense anymore.. > > IOPORT_V2 ? Or something.. I've asked for a nice big explanatory comment to be added beside the parameter's definition. Also we should treat this field as a version number, so baking a fixed version into its name is not a good idea. With the explanatory comment, I think its existing name is good enough. To do much better the name would have to become cumbersomely long. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |