Re: [Xen-devel] [PATCH V3 0/6] firmware changes as part of QEMU/Xen merge.

[Keir Fraser <keir@xxxxxxx>]

On 29/10/2010 14:16, "Keir Fraser" <keir@xxxxxxx> wrote:

>> Should it be called something else than HVM_PARAM_ACPI_NEW_IOPORT ?
>> After a couple of years "NEW" might not make much sense anymore..
>> 
>> IOPORT_V2 ? Or something..
> 
> I've asked for a nice big explanatory comment to be added beside the
> parameter's definition. Also we should treat this field as a version number,
> so baking a fixed version into its name is not a good idea. With the
> explanatory comment, I think its existing name is good enough. To do much
> better the name would have to become cumbersomely long.

That said, HVM_PARAM_ACPI_IOPORTS_LOCATION might be better... I'm not
personally that fussed either way however.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel