Re: [Xen-devel] [PATCH][VTD] bug fix for EPT/VT-d table sharing

[Olaf Hering <olaf@xxxxxxxxx>]

On Fri, Jan 07, Kay, Allen M wrote:

> >@@ -548,17 +533,12 @@ static int inline iommu_flush_iotlb_psi(
> >     if ( !cap_pgsel_inv(iommu->cap) )
> >         return iommu_flush_iotlb_dsi(iommu, did, flush_non_present_entry, 
> > flush_dev_iotlb);
> > 
> >-    /*
> >-     * PSI requires page size is 2 ^ x, and the base address is naturally
> >-     * aligned to the size
> >-     */
> >-    align = get_alignment(addr >> PAGE_SHIFT_4K, pages);
> >     /* Fallback to domain selective flush if size is too big */
> >-    if ( align > cap_max_amask_val(iommu->cap) )
> >+    if ( order > cap_max_amask_val(iommu->cap) )

This leaves 'align' uninitialized when flush->iotlb() is called.

iommu.c:546: error: 'align' may be used uninitialized in this function


Olaf


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel