[Xen-devel] RE: [PATCH] mem_sharing: fix race condition of nominate and unshare

[MaoXiaoyun <tinnycloud@xxxxxxxxxxx>]

Hi Jui_hao:
 
    Page_make_private() --> page_set_owner(page, d)  sets page owner when page_make_private success.
    But in fact, I remember, when the Error log shows up, page_make_private failed, thus
    page_set_owner(page, d) is not called.    
 
> Date: Tue, 11 Jan 2011 14:32:51 +0800
> Subject: Re: [PATCH] mem_sharing: fix race condition of nominate and unshare
> From: juihaochiang@xxxxxxxxx
> To: tinnycloud@xxxxxxxxxxx
> CC: tim.deegan@xxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxx
>
> Hi, all:
>
> I disable Rich formatting in gmail, does the format looks good now?
> To tinnycloud: hvm_hap_nested_page_fault() will be called when a guest
> writes a shared page.
>
> 2011/1/11 MaoXiaoyun <tinnycloud@xxxxxxxxxxx>
> >
> > Hi Tim:
> >
> >       Sorry for the inconvenience, I think it's better now when I reply directly from hotmail.
> >
> >       It looks like when unshare(), page_set_owner is forgetten, right?
>
> Inside unshare(), it does the following
> (1) page_make_private() --> page_set_owner(page, d ) to update
> page_info structure. So there is no need for you to add page_set_owner
> explicitly.
> (2) set_shared_p2m_entry() to update the page table
> From your log file, the page_make_private() is not called/executed
> properly. Could you debug into it also?
>
> Thanks,
> Jui-Hao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel