[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 5/6] libxl: vncviewer: unconditionally read listen port address and password



Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 5/6] libxl: vncviewer: 
unconditionally read listen port address and password"):
> On Tue, 1 Feb 2011, Ian Jackson wrote:
> > +
> > +    if ( autopass )
> > +        vnc_pass = libxl__xs_read(&gc, XBT_NULL,
> > +                                  libxl__sprintf(&gc,
> >                              "/local/domain/%d/console/vnc-pass", domid));
> > -    }
> >  
> 
> these changes don't follow the coding style (but even the original code
> does not).

Indeed.  I thought it best during the freeze to avoid making needless
changes, and also I didn't want to mix a code style cleanup with my
functional change.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.