Re: [Xen-devel] [PATCH] qemu-xen: read default pci passthrough values

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("[Xen-devel] [PATCH] qemu-xen: read default pci 
passthrough values"):
> If there are no devices assigned to the domain at boot, we don't read
> the default pci passthrough parameters.
> This patch fixes it.

The semantics you intend seem sensible, but:

The variable "num" seems completely unused after we went to all the
effort of reading num_devs to get it.  The code seems to read
.../num_devs just to check that the key exists, and doesn't mind "0"
as an answer.  With your patch applied, we don't even care whether the
key exists.

So why do we bother reading .../num_devs and converting it to an
integer and assigning it to nums ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel