Re: [Xen-devel] Recent xl and network-route scripts

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Tue, 2011-03-15 at 18:12 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] Recent xl and network-route scripts"):
> > On Sun, 2011-03-13 at 18:53 +0000, W. Michael Petullo wrote:
> > > The former pattern is what "vif-setup" needs.
> > 
> > Thanks, I sent out a patch last week "libxl: use full path to vif
> > hotplug script script" which addresses this discrepancy.
> 
> I think we should _allow_ the user to specify the complete path to a
> script, but not require them to.  Your existing patch 1/2 doesn't do
> that.

It's over and above whatr xend supports but I agree it's a good idea.

> How about something like:
> 
> -    flexarray_append(back, nic->script);
> +    flexarray_append(back, nic->script[0]=='/' ? nic->script :
> +     libxl__sprintf(&gc, "%s/%s", libxl_xen_script_dir_path(), nic->script));

Assuming there's an "if (nic-script)" above this context I think makes
sense.

Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel