Re: [Xen-devel] [PATCH 29 of 45] gcc-4.6 compile fix: xen/arch/x86/cpu/intel.c

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 19.05.11 at 21:05, Olaf Hering <olaf@xxxxxxxxx> wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1305824415 -7200
> # Node ID 30c6a8c61c90f896ba2ef9ee2f4f417cea7c1ffa
> # Parent  c8e4a190705be60bae9cff30c90a8a4a307979ec
> gcc-4.6 compile fix: xen/arch/x86/cpu/intel.c
> 
> intel.c: In function 'set_cpuidmask':
> intel.c:36:14: error: variable 'extra' set but not used 
> [-Werror=unused-but-set-variable]

No, please don't push this - it was a mistake that "extra" wasn't
used, and 
http://lists.xensource.com/archives/html/xen-devel/2011-05/msg00753.html 
corrects this.

Jan

> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> 
> diff -r c8e4a190705b -r 30c6a8c61c90 xen/arch/x86/cpu/intel.c
> --- a/xen/arch/x86/cpu/intel.c        Thu May 19 19:00:14 2011 +0200
> +++ b/xen/arch/x86/cpu/intel.c        Thu May 19 19:00:15 2011 +0200
> @@ -33,8 +33,6 @@ struct movsl_mask movsl_mask __read_most
>   */
>  static void __devinit set_cpuidmask(const struct cpuinfo_x86 *c)
>  {
> -     const char *extra = "";
> -
>       if (!~(opt_cpuid_mask_ecx & opt_cpuid_mask_edx &
>              opt_cpuid_mask_ext_ecx & opt_cpuid_mask_ext_edx))
>               return;
> @@ -51,7 +49,6 @@ static void __devinit set_cpuidmask(cons
>                     opt_cpuid_mask_edx);
>               if (!~(opt_cpuid_mask_ext_ecx & opt_cpuid_mask_ext_edx))
>                       return;
> -             extra = "extended ";
>               break;
>  /* 
>   * CPU supports this feature if the processor signature meets the 
> following:
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx 
> http://lists.xensource.com/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel