Re: [Xen-devel] [PATCH V3 0/3] xen-blkfront/xen-blkback trim support

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Mon, Aug 29, 2011 at 03:50:28PM +0800, Li Dongyang wrote:
> On Sat, Aug 27, 2011 at 12:56 AM, Konrad Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx> wrote:
> > On Wed, Aug 24, 2011 at 05:23:42PM +0800, Li Dongyang wrote:
> >> Dear list,
> >> this is the V3 of the trim support for xen-blkfront/blkback,
> >> thanks for all your reviews.
> >> and when I looked back at Owen's patch in Dec 2010,
> >> http://lists.xensource.com/archives/html/xen-devel/2010-12/msg00299.html
> >> this patch above also add the trim union to blkif_x86_{32|64}_request,
> >> and take care of trim request in blkif_get_x86{32|64}_req(),
> >> however, in the later versions, the part is just gone. I wonder if it is
> >> needed here? Thanks.
> >
> > Are you referring to git commit 51de69523ffe1c17994dc2f260369f29dfdce71c
> > xen: Union the blkif_request request specific fields
> that's the patch merged, the link I gave above was the previous
> version cooked up by
> Owen, and the patch in the link has changes to struct
> blkif_x86_{32|64}_request related stuffs,
> but that;s gone in the merged version, so I'm not sure if the gone
> part is needed here, Thanks

Well, I presume that you tested this patchset you are posting. If it
works properly (and you do see the discard operations in dom0) then
you do not need the extra parts.

You are testing this patchset on SSDs, right?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel