[Xen-devel] Re: [PATCH] libxlu: correctly parse disk "backendtype" field

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Daniel De Graaf writes ("Re: [PATCH] libxlu: correctly parse disk "backendtype" 
field"):
> On 10/07/2011 05:41 PM, Ian Campbell wrote:
> > On Fri, 2011-10-07 at 21:50 +0100, Daniel De Graaf wrote:
> >> The expression for backendtype was missing a comma.

Good catch, thanks.

> > This appears correct even though things seem to work without, at least:

Daniel's fix is correct.  Without the ",?", the "backendtype=..."
match would not eat the trailing comma.  The comma would then be
matched by the positional parameter rule, with effects ranging from
unhelpful to fatal.  Ie, it would parse as if you'd written
   backendtype=<something>,,vdev=<blah>
etc.

> > (we need a signed-off-by I suspect)

Thanks, yes.

> Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel