[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 06/25] libelf-loader: introduce elf_load_image
On 09/12/2011 15:41, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote: >> (I didn't look >> at the ARM bits, but if there things are done differently that's likely a >> mistake). > > This ARM port has no PV guests so it has no "user" in the sense that > x86's copy_to_user means, so copy_to_user and copy_to_guest are both the > same and do things the HVM way. > > Maybe the right thing to do is to not supply copy_to_user on ARM at all. > I had feared this would be a big bit of string to pull on but it seems > that copy_to_user isn't actually widely used in common code: > $ rgrep --binary-files=without-match copy_to_user xen | grep -vE > x86\|ia64\|asm > xen/common/gdbstub.c: r = gdb_arch_copy_to_user((void*)addr, > (void*)&val, 1); > xen/include/linux/gdbstub.h:unsigned int gdb_arch_copy_to_user( > xen/include/xen/gdbstub.h:unsigned int gdb_arch_copy_to_user( copy_to/from_user isn't used by and doesn't really have any meaning to common code. You can leave them out. -- Keir > Stefano, what do you think? _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |