Re: [Xen-devel] [PATCH v2 06/25] libelf-loader: introduce elf_load_image

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 9 Dec 2011, Ian Campbell wrote:
> This ARM port has no PV guests so it has no "user" in the sense that
> x86's copy_to_user means, so copy_to_user and copy_to_guest are both the
> same and do things the HVM way.
> 
> Maybe the right thing to do is to not supply copy_to_user on ARM at all.
> I had feared this would be a big bit of string to pull on but it seems
> that copy_to_user isn't actually widely used in common code:
> $ rgrep --binary-files=without-match copy_to_user xen | grep -vE 
> x86\|ia64\|asm
> xen/common/gdbstub.c:        r = gdb_arch_copy_to_user((void*)addr, 
> (void*)&val, 1);
> xen/include/linux/gdbstub.h:unsigned int gdb_arch_copy_to_user(
> xen/include/xen/gdbstub.h:unsigned int gdb_arch_copy_to_user(

We are not compiling gdbstub at the moment.

> Stefano, what do you think?

I think we should only provide the *_guest functions in our port.

The only downside is that the clear_user patch will grow also to
implement clear_guest for ia64 and x86 as well. Nothing difficult, but
more code.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel