[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V3 1/2] xen/granttable: Support sub-page grants





On 2011-12-12 15:10, Ian Campbell wrote:
On Mon, 2011-12-12 at 03:16 +0000, ANNIE LI wrote:
Please can you name the arguments here and then refer to them by name in
the comments instead of all this "First parameter", "second one" stuff.

Similarly for the existing comments sorry I didn't notice this in
previous review.
Please check following comments in gnttab_ops, I changed the "First
parameter", "second one" into parameter name. However, it looks not very
consistent with parameters format of function fn since only parameter
type exists, not name.
You can give the parameters names in the function pointers too, that's
what I was suggesting.

e.g.:
          int (*map_frames)(unsigned long *frames, unsigned int nr);

Ok, I will correct comments and add parameter names of existing function in a third patch. Sub-page and trans patches should contain corrected comments and parameter names directly.

Thanks
Annie
Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.