Re: [Xen-devel] [PATCH] Qemu MSI Cleaning Up

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.12.11 at 07:01, "Shan, Haitao" <haitao.shan@xxxxxxxxx> wrote:
> Fine to me! Thanks, Jan!
> 
> Shan Haitao

Ian,

any chance to get this committed then?

Also, how are we going to deal with the "modern" qemu tree (is
passthrough for Xen implemented at all in that tree)?

Thanks, Jan


>> -----Original Message-----
>> From: Stefano Stabellini [mailto:stefano.stabellini@xxxxxxxxxxxxx]
>> Sent: Wednesday, December 07, 2011 3:08 AM
>> To: Jan Beulich
>> Cc: Stefano Stabellini; Haitao Shan; Ian Jackson; Shan, Haitao; xen-
>> devel@xxxxxxxxxxxxxxxxxxx; Keir (Xen.org)
>> Subject: Re: [Xen-devel] [PATCH] Qemu MSI Cleaning Up
>> 
>> On Tue, 6 Dec 2011, Jan Beulich wrote:
>> > >>> On 02.12.11 at 13:40, Stefano Stabellini
>> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
>> > > The two mapping and unmapping big chuncks of code looks very similar
>> > > apart from the DPCI_ADD_MAPPING/DPCI_REMOVE_MAPPING
>> parameter.
>> > > Could they be refactored into a single function called
>> > > "change_msix_mappings"?
>> > > This is more or less what I have in mind:
>> > >
>> > > change_msix_mappings(assigned_device, DPCI_REMOVE_MAPPING);
>> > >
>> > > update mmio_base_addr
>> > >
>> > > change_msix_mappings(assigned_device, DPCI_ADD_MAPPING);
>> >
>> > Please see below/attached for the outcome. Without MSI-X capable
>> > devices to pass through, I have to rely on others to do some testing
>> > on this.
>> 
>> It looks fine.
>> Haitao, are you happy with the new patch?




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel