Re: [Xen-devel] [PATCH 10/12] arm: stub out PoD

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-01-20 at 12:35 +0000, Tim Deegan wrote:
> At 12:29 +0000 on 20 Jan (1327062595), Ian Campbell wrote:
> > On Fri, 2012-01-20 at 12:20 +0000, Stefano Stabellini wrote:
> > > Could we have a proper stub function or a static inline rather than an
> > > #define?
> > 
> > I tried that, it would require pulling in more headers etc. This is
> > really just a stop gap until we implement enough p2m to support pod
> > properly. I left the real prototypes in the comment for reference.
> 
> We could just as easily have 
> 
> static inline int 
> guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn,
>                                       unsigned int order)
> {
>     return -ENOSYS;
> }
> 
> &c, for no extra effort (and for the same effect).  A matter of style is
> all. 

That is exactly what required pulling in more headers.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel