Re: [Xen-devel] [PATCH 8/9] libxl: Introduce libxl__ev_devstate

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 8/9] libxl: Introduce 
libxl__ev_devstate"):
> On Tue, 2012-01-24 at 17:33 +0000, Ian Jackson wrote:
> > So, no.  When the timeout happens, the ev xswatch is deregistered and
> > can thereafter no longer generate callbacks.  If there are any
> > xenstore watch events in the pipeline for deregistered ev_xswatch's,
> > they're discarded by watchfd_callback.
> 
> What happens if the watch occurs and is delivered (in a different
> thread) e.g. just before devstate_timeout calls
> libxl__ev_devstate_cancel? The watch callback will be delivered but we
> will unconditionally go on to deliver the cancel callback as well.

All of these callback functions are called with the lock held, so
there aren't any of these kind of races.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel