Re: [Xen-devel] [PATCH v10 6/7] libxl: use new qemu at the location where xen-unstable installs it

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-01-16 at 16:52 +0000, stefano.stabellini@xxxxxxxxxxxxx
wrote:
> From: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  tools/libxl/libxl_dm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 97d91b4..9d84b6f 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -58,7 +58,7 @@ const char *libxl__domain_device_model(libxl__gc *gc,
>              dm = libxl__abs_path(gc, "qemu-dm", libxl_libexec_path());
>              break;
>          case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> -            dm = libxl__strdup(gc, "/usr/bin/qemu");
> +            dm = libxl__abs_path(gc, "qemu", libxl_libexec_path());

The actual installed path (in staging tree now)
is /usr/lib/xen/bin/qemu-system-i386 so if I boot a guest with
device_model_version="qemu-xen" then, as you might expect, I get:
        libxl: error: libxl_dm.c:809:libxl__create_device_model: device model 
/usr/lib/xen/bin/qemu is not executable: No such file or directory
        libxl: error: libxl_create.c:579:do_domain_create: failed to create 
device model: -3
        libxl: error: libxl_dm.c:926:libxl__destroy_device_model: Couldn't find 
device model's pid: No such file or directory
        libxl: error: libxl.c:796:libxl_domain_destroy: 
libxl__destroy_device_model failed for 21

I can add device_model_override="/usr/lib/xen/bin/qemu-system-i386" and
then things work as expected.

Presumably if I build my tools for 64 bit it will be qemu-system-amd64.

So, should we fix libxl, the qemu build or our build integration?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel