Re: [Xen-devel] [PATCH v3] libxl: add support for yajl 2.x

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[Xen-devel] [PATCH v3] libxl: add support for yajl 
2.x"):
> libxl: add support for yajl 2.x
> 
> This patch adds support for yajl versions 2.x, while retaining 1.x
> compatibility. All the needed ifdefs can be found in libxl_json.h.

Thanks.  I'm afraid this needs a refresh:

 patching file tools/libxl/libxl_json.h
 Hunk #1 FAILED at 16.
 1 out of 1 hunk FAILED -- saving rejects to file tools/libxl/libxl_json.h.rej

Also, while you're at it:
> +static inline yajl_gen libxl__yajl_gen_alloc(const yajl_alloc_funcs 
> *allocFuncs)
> +{
> +    return yajl_gen_alloc(allocFuncs);
> +}
> +#else

A couple of blank lines around this #ifs and #elses might be nice.
And also I would say
  #else /* !HAVE_YAJL_V2 */
and
  #endif /* !HAVE_YAJL_V2 */

(But I would have committed it without those changes if it had applied
cleanly.)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel