Re: [Xen-devel] [PATCH v3] libxl: add support for yajl 2.x

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

2012/1/27 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> Roger Pau Monne writes ("[Xen-devel] [PATCH v3] libxl: add support for yajl 
> 2.x"):
>> libxl: add support for yajl 2.x
>>
>> This patch adds support for yajl versions 2.x, while retaining 1.x
>> compatibility. All the needed ifdefs can be found in libxl_json.h.
>
> Thanks. ÂI'm afraid this needs a refresh:
>
> Âpatching file tools/libxl/libxl_json.h
> ÂHunk #1 FAILED at 16.
> Â1 out of 1 hunk FAILED -- saving rejects to file tools/libxl/libxl_json.h.rej
>
> Also, while you're at it:
>> +static inline yajl_gen libxl__yajl_gen_alloc(const yajl_alloc_funcs 
>> *allocFuncs)
>> +{
>> + Â Âreturn yajl_gen_alloc(allocFuncs);
>> +}
>> +#else
>
> A couple of blank lines around this #ifs and #elses might be nice.
> And also I would say
> Â#else /* !HAVE_YAJL_V2 */
> and
> Â#endif /* !HAVE_YAJL_V2 */
>
> (But I would have committed it without those changes if it had applied
> cleanly.)

I've sent and updated version, sorry for the delay, my local mercurial
repro was totally borked, don't know why...

> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel