Re: [Xen-devel] [PATCH 08 of 10] libxl: Implement libxl_sched_credit_param_[gs]et

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On Tue, 2012-02-21 at 17:51 +0000, Ian Jackson wrote:
> George Dunlap writes ("[Xen-devel] [PATCH 08 of 10] libxl: Implement 
> libxl_sched_credit_param_[gs]et"):
> > Implement functions to set credit scheduler global parameters.
> 
> Again, just some niggles:
> 
> > +int libxl_sched_credit_param_get(libxl_ctx *ctx, uint32_t poolid, 
> > libxl_sched_credit_param *scinfo)
> 
> Long line here and in _set.
> 
> Shouldn't this be "params" rather than "param" since it sets several
> parameters ?

Hmm, I suppose so.  I think I accidentally said "param" because I
originally wrote the patch series, the structure actually only contained
one parameter.  Then I thought I might as well do both at the same time,
but didn't have to re-write this patch. :-)

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel