Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix compile error of libvirt

["Bamvor Jian Zhang" <bjzhang@xxxxxxxx>]

Ian Jackson  wrote: 
>Bamvor Jian Zhang writes ("Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix 
>compile error of libvirt"):
>> Ian Jackson wrote: 
>> > Users of libxl should not be using libxc directly and therefore should 
>> > not be including xenctrl.h. 
>...
>> but after your commit "23174:751c6dcec0d4"(remove xenctrl.h from libxl.h), 
>> the aplication(like libvirt) compile fail. How do i deal with it? 
>> it seems that add __XEN_TOOLS_ to libvirt code is not good. 
>
>Can you tell us the error message you get ?  I think the problem is
>probably that libvirt is trying to use libxc directly.
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I../gnulib/lib 
-I../gnulib/lib -I../include -I../include -I../src/util -DIN_LIBVIRT 
-I../src/conf -I../src/xenxs -I/usr/include/libxml2 -Wall -W -Wformat-y2k 
-Wformat-security -Winit-self -Wmissing-include-dirs -Wunused -Wunknown-pragmas 
-Wstrict-aliasing -Wshadow -Wpointer-arith -Wbad-function-cast -Wcast-align 
-Wwrite-strings -Wlogical-op -Waggregate-return -Wstrict-prototypes 
-Wold-style-definition -Wmissing-prototypes -Wmissing-declarations 
-Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls 
-Wnested-externs -Winline -Winvalid-pch -Wvolatile-register-var 
-Wdisabled-optimization -Wattributes -Wcoverage-mismatch -Wmultichar 
-Wdeprecated-declarations -Wdiv-by-zero -Wendif-labels -Wextra 
-Wformat-contains-nul -Wformat-extra-args -Wformat-zero-length -Wformat=2 
-Wmultichar -Wnormalized=nfc -Woverflow -Wpointer-to-int-cast -Wpragmas 
-Wno-missing-field-initializers -Wno-sign-compare -Wno-format-nonliteral 
-fstack-protector-all --param=ssp-buffer-size=4 -fexceptions 
-fasynchronous-unwind-tables -fdiagnostics-show-option -funit-at-a-time 
-fipa-pure-const -Werror -g -O2 -MT libvirt_driver_libxl_la-libxl_conf.lo -MD 
-MP -MF .deps/libvirt_driver_libxl_la-libxl_conf.Tpo -c libxl/libxl_conf.c  
-fPIC -DPIC -o .libs/libvirt_driver_libxl_la-libxl_conf.o
In file included from /usr/include/libxl.h:140,
                 from libxl/libxl_conf.c:29:
/usr/include/xen/sysctl.h:31:2: error: #error "sysctl operations are intended 
for use by node control tools only"
In file included from /usr/include/xen/sysctl.h:35,
                 from /usr/include/libxl.h:140,
                 from libxl/libxl_conf.c:29:
/usr/include/xen/domctl.h:32:2: error: #error "domctl operations are intended 
for use by node control tools only"
In file included from /usr/include/xen/sysctl.h:35,
                 from /usr/include/libxl.h:140,
                 from libxl/libxl_conf.c:29:


>Now there is an existing libxc/libxenstore-based libvirt driver for
>Xen but that should be in a separate file.  The libxl-based driver
>should not use libxc.
>
>Ian.






_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel