Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix compile error of libvirt

["Bamvor Jian Zhang" <bjzhang@xxxxxxxx>]

Ian Jackson wrote: 
> Bamvor Jian Zhang writes ("[Xen-devel] [xen-devel] [PATCH] libxl: fix compile 
>  
> error of libvirt"): 
> >  
> > a, libxl_event.h is included in libxl.h. So, the former one also need to be 
> > installed. 
>  
> Well spotted.  However, I'm afraid your mail has been very badly 
> mangled by whatever program you used to send it.  For this patch I 
> reconstructed the change by hand and have committed it. 
>  
thanks. I will be careful in future.

> > b, define __XEN_TOOLS__ in libxl.h: 
> > the head file "xen/sysctl.h" need check this macro. 
>  
> I don't think this is correct. 
>  
> > It is the same way used by the xen libxc public  
> headers(tools/libxc/xenctrl.h 
> > and tools/libxc/xenctrlosdep.h). 
>  
> Users of libxl should not be using libxc directly and therefore should 
> not be including xenctrl.h. 
>  
> Note that the API for libxl has changed in xen-unstable.hg compared to 
> 4.1, and further changes are forthcoming.  So there will have to be 
> changes in libvirt. 
>  
but after your commit "23174:751c6dcec0d4"(remove xenctrl.h from libxl.h), the 
aplication(like libvirt) compile fail. How do i deal with it? 
it seems that add __XEN_TOOLS_ to libvirt code is not good. 
> Thanks, 
> Ian. 
>  
Thanks
bamvor



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel