Re: [Xen-devel] [PATCH 2 of 2] libxc: Print domain ID in save restore messages

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

George Dunlap writes ("Re: [Xen-devel] [PATCH 2 of 2] libxc: Print domain ID in 
save restore messages"):
> On Fri, 2012-03-09 at 18:33 +0000, Ian Campbell wrote:
> > They already have to remember to write IPRINTF instead of printf(), most
> > people will just copy whatever is used nearby, whether that is IPRINTF,
> > _IPRINTF or DIPRINTF...

I would tend to agree.

> > > (And it requires me to change 10x as many LoC.)
> > 
> > That's irritating but not a show stopper IMHO.

I agree.

> > Coming from the other angle can you omit all uses of _IPRINTF by passing
> > the context around a few more places? I'd have expected that everything
> > in xc_domain_save.c was ultimately called from xc_domain_save and
> > therefore the is a dom which could be printed?
> 
> There's a non-static function xc_map_m2p() which is defined in
> xc_domain_save.c, but called from xc_offline_page.c and
> tools/tests/mce-test/tools/xce-mceinj.c.  That should probably then be
> moved to another file in any case.
> 
> If I move that function to a different file, so that there are no
> _IPRINTF's, would that suffice?

Like Ian, I would still prefer to avoid the #undeffery.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel