Re: [Xen-devel] [PATCH 15/20] libxl: include <_libxl_paths.h> in libxl_internal.h

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

2012/3/20 Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>:
> 2012/3/20 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
>> On Fri, 2012-03-16 at 16:26 +0000, Ian Jackson wrote:
>>> Ie, we permit general code in libxl direct access to the manifest
>>> constants such as XEN_RUN_DIR. ÂThis simplifies their use in (eg)
>>> format strings.
>>>
>>> This might be controversial because it will make it difficult to make
>>> any of these runtime-configurable later without changing lots of use
>>> sites. ÂBut I don't think it's likely we'll want to do that.
>>
>> I don't have any particular feeling one way or the other about this
>>
>> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> _libxl_paths.h should be generated before trying to use
> libxl_internal.h, if not the build fails.

This also removes the libxl_paths.c dependency, which is no longer necessary:

8<-------------------------------------------------------------

libxl: add _libxl_paths.h as a prerequisite to libxl_internal.h

Also remove the libxl_paths.c dependency, which is no longer necessary.

Signed-off-by: Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
---
 tools/libxl/Makefile |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index b30d11f..a88827a 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -102,11 +102,9 @@ _libxl_list.h:
$(XEN_INCLUDE)/xen-external/bsd-sys-queue-h-seddery $(XEN_INCLUDE
        perl $^ --prefix=libxl >$@.new
        $(call move-if-changed,$@.new,$@)

-libxl_paths.c: _libxl_paths.h
-
 libxl.h: _libxl_types.h
 libxl_json.h: _libxl_types_json.h
-libxl_internal.h: _libxl_types_internal.h
+libxl_internal.h: _libxl_types_internal.h _libxl_paths.h
 libxl_internal_json.h: _libxl_types_internal_json.h

 $(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): libxl.h
-- 
1.7.2.5

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel