Re: [Xen-devel] [PATCH 6/6] xl/libxl: implement QDISK libxl_device_disk_local_attach

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 27 Mar 2012, Ian Jackson wrote:
> Stefano Stabellini writes ("[PATCH 6/6] xl/libxl: implement QDISK 
> libxl_device_disk_local_attach"):
> > - Spawn a QEMU instance at boot time to handle disk local attach
> > requests.
> 
> This is a bit strange.  Why does this need to be a single daemon ?
> Can't we have one qemu per disk ?

Why is a bit strange? It has always been the case that QEMU PV would
take care of all the PV backends for a single domain. Moreover why would
you want more QEMUs when you can handle everything you need with just
one and a single thread (except the inevitable xenstore thread)?


> > - Implement libxl_device_disk_local_attach for QDISKs in terms of a
> > regular disk attach with the frontend and backend running in the same
> > domain.
> ...
> > +                    LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "libxl__alloc_vdev 
> > failed\n");
> 
> Too many long lines for me to comfortably read I'm afraid.

I'll fix all the long lines I can find in the series, sorry about that.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel