Re: [Xen-devel] [PATCH v4 5/8] xl/libxl: add a blkdev_start parameter

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("[Xen-devel] [PATCH v4 5/8] xl/libxl: add a 
blkdev_start parameter"):
> Introduce a blkdev_start in xl.conf and a corresponding string in
> libxl_domain_build_info.
...
> +        libxl_device_disk **new_disk,
> +        char *blkdev_start)

Shouldn't this be  const char *  ?

You should mention in the commit message that in this patch the value
is still ignored - ie, it will be used later.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel