Re: [Xen-devel] [PATCH 0 of 2] Add libxc API that sets mem_access type for an array of gfns

[Tim Deegan <tim@xxxxxxx>]

At 18:36 -0700 on 26 Apr (1335465381), Aravindh Puthiyaparambil wrote:
> > - this is wrong:
> > > -        old_entry = *ept_entry;
> > > +        old_entry->epte = ept_entry->epte;
> > You should follow the code and see what uses old_entry and you'll see
> > that within the function old_entry->mfn is used (your diff changes the
> > line that uses it) and ept_free_entry also accesses mfn.
> 
> I will fix that.
> 
> > - are you sure you can move the ept_sync_domain call past the iommu code?
> >
> 
> I was hoping Tim would give me feedback about that.

I'm afraid I won't be able to review this code until next week.  This
change is already too late for the 4.2 freeze, though, so there's plenty
of time to get it right after we branch.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel