Re: [Xen-devel] [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (RFC)

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Borislav Petkov wrote:
> On Wed, May 30, 2012 at 03:20:03PM +0000, Liu, Jinsong wrote:
>>>> IMO currently there are 2 options:
>>>> 1). use the original approach (implicitly redirect /dev/mcelog to
>>>> xen_mce_chrdev_device) --> what point of this approach do you think
>>>> unreasonable? It just remove a 'static' from native mce code! 2).
>>>> use another /dev/xen-mcelog interface, with another misc minor
>>>> '226' 
>>> 
>>> The 2) is no good.
>>> 
>>> 3) What about moving the corresponding other users (so
>>> threshold_init_device), to be at late_initcall and the mce to be at
>>> late_initcall_sync
>> 
>> I can try, but only if Boris would not jump out.
>> and it can only be tested by Boris at AMD platform :(
> 
> Sure, I'll test it.
> 
> However, it should be a separate patch, not merged with this one.
> 
> So, I don't see anything speaking against making
> threshold_init_device a late_initcall leading to the following order:
> 
> device_initcall <- xen
> device_initcall_sync <- arch/x86
> fs_initcall <- threshold_init_device

do you mean 'late_initcall <- threshold_init_device'?

> 
> and the "xen" line not happening on baremetal; which shouldn't change
> anything noticeably in the init-order mce-wise.
> 
> Also, add a comment at the end of mce_amd.c saying why
> threshold_init_device should be last.
> 

OK, good, we will use this approach, I will do it tomorrow morning.
Thanks Konrad and Boris's suggestion!


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel