Re: [Xen-devel] [PATCH] tools: honour --libdir when it is passed to ./configure

[Matt Wilson <msw@xxxxxxxxxx>]

On Wed, Jun 20, 2012 at 01:51:17AM -0700, Roger Pau Monne wrote:
> Matt Wilson wrote:
> > Signed-off-by: Matt Wilson<msw@xxxxxxxxxx>
> 
> Thanks for the patch! The way FSIMAGE_FSDIR is set is really wrong.

No problem. The FSIMAGE_FSDIR bit was a gross hack so I didn't have to
touch autoconf, which I try to avoid. ;-)

> > diff -r 32034d1914a6 -r 0a592e08ac31 config/SunOS.mk
> > --- a/config/SunOS.mk       Thu Jun 07 19:46:57 2012 +0100
> > +++ b/config/SunOS.mk       Wed Jun 20 00:40:15 2012 +0000
> > @@ -24,7 +24,6 @@ BINDIR = $(PREFIX)/bin
> >   INCLUDEDIR = $(PREFIX)/include
> >   LIBLEAFDIR = lib
> >   LIBLEAFDIR_x86_64 = lib/amd64
> > -LIBDIR = $(PREFIX)/$(LIBLEAFDIR)
> >   LIBDIR_x86_64 = $(PREFIX)/$(LIBLEAFDIR_x86_64)
> >   MANDIR = $(PREFIX)/share/man
> >   MAN1DIR = $(MANDIR)/man1
> 
> Can we clean this a little bit more, and remove LIBDIR_x86_32,
> LIBLEAFDIR_x86_64, LIBDIR_x86_64, LIBDIR_x86_32 and LIBLEAFDIR?

I was thinking that too, but was a little worried about expectations
on Solaris. Maybe I souldn't.

> > -CFLAGS += -Wno-unknown-pragmas -I$(XEN_ROOT)/tools/libfsimage/common/
> > +CFLAGS += -Wno-unknown-pragmas -I$(XEN_ROOT)/tools/libfsimage/common/ 
> > -DFSIMAGE_FSDIR=\"$(FSDIR)\"
> 
> I would prefer to set FSIMAGE_FSDIR or an equivalent define in 
> tools/config.h and include that header in 
> tools/libfsimage/common/fsimage_plugin.h, so we don't have to pass that 
> value from the compiler command line.

Makes sense.

Matt

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel