Re: [Xen-devel] [PATCH 1/2] libxl: set stdvga=1 by default when creating a hvm guest

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-06-26 at 07:02 +0100, Ren, Yongjie wrote:
> libxl: set stdvga=1 by default when creating a hvm guest
> 
> Most of the modern OSes (e.g. Windows XP, Windows 7, RHEL6.x, Ubuntu, Fedora) 
> support VBE 2.0 or later.
> So, select a standard VGA card with VBE as the default emulated graphics 
> device.

I'm not expert on the graphics side of HVM, but on the face of it
switching the default to something more modern seems like a reasonable
idea, although I'm not sure if we should be doing this for 4.2 at this
point.

I've CCd Tim and Stefano for input from the HVM and QEMU sides.

> It's also a workaround for the following bug.
> http://bugzilla.xen.org/bugzilla/show_bug.cgi?id=1812

Do you understand the root cause of that bug?

It's hard to see how detaching a VF relates to the VGA emulation in use.
Can you explain it? Are you sure you aren't just masking the real issue
here?

> Signed-off-by: Yongjie Ren <yongjie.ren@xxxxxxxxx>
> 
> diff -r e08cf97e76f0 tools/libxl/libxl_create.c
> --- a/tools/libxl/libxl_create.c      Mon Jun 25 13:41:32 2012 +0200
> +++ b/tools/libxl/libxl_create.c      Tue Jun 26 12:41:46 2012 +0800
> @@ -248,7 +248,7 @@
>              if (!b_info->u.hvm.boot) return ERROR_NOMEM;
>          }
>  
> -        libxl_defbool_setdefault(&b_info->u.hvm.stdvga, false);
> +        libxl_defbool_setdefault(&b_info->u.hvm.stdvga, true);
>          libxl_defbool_setdefault(&b_info->u.hvm.vnc.enable, true);
>          if (libxl_defbool_val(b_info->u.hvm.vnc.enable)) {
>              libxl_defbool_setdefault(&b_info->u.hvm.vnc.findunused, true);
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel