Re: [Xen-devel] [PATCH 1/2] libxl: set stdvga=1 by default when creating a hvm guest

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 26 Jun 2012, Ian Campbell wrote:
> On Tue, 2012-06-26 at 07:02 +0100, Ren, Yongjie wrote:
> > libxl: set stdvga=1 by default when creating a hvm guest
> > 
> > Most of the modern OSes (e.g. Windows XP, Windows 7, RHEL6.x, Ubuntu, 
> > Fedora) support VBE 2.0 or later.
> > So, select a standard VGA card with VBE as the default emulated graphics 
> > device.
> 
> I'm not expert on the graphics side of HVM, but on the face of it
> switching the default to something more modern seems like a reasonable
> idea, although I'm not sure if we should be doing this for 4.2 at this
> point.
> 
> I've CCd Tim and Stefano for input from the HVM and QEMU sides.

I think it is a good thing.
The only thing to keep in mind is that QEMU upstream is switching to
16MB of videoram for stdvga. So at some point in the near future
upstream QEMU will stop working correctly with xen 4.2, unless we bump
the videoram to 16MB too.


> > It's also a workaround for the following bug.
> > http://bugzilla.xen.org/bugzilla/show_bug.cgi?id=1812
> 
> Do you understand the root cause of that bug?
> 
> It's hard to see how detaching a VF relates to the VGA emulation in use.
> Can you explain it? Are you sure you aren't just masking the real issue
> here?

Indeed. We cannot possibly accept the patch on the basis that it looks
like it is masking an unrelated pci-passthrough bug.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel