Re: [Xen-devel] [PATCH v9 08/17] libxl: convert libxl_device_disk_add to an async op

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-07-13 at 10:44 +0100, Roger Pau Monne wrote:
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index c730ac5..f3161d5 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -675,7 +675,9 @@ void libxl_vcpuinfo_list_free(libxl_vcpuinfo *,
> int nr_vcpus);
>   */
> 
>  /* Disks */
> -int libxl_device_disk_add(libxl_ctx *ctx, uint32_t domid,
> libxl_device_disk *disk);
> +int libxl_device_disk_add(libxl_ctx *ctx, uint32_t domid,
> +                          libxl_device_disk *disk,
> +                          const libxl_asyncop_how *ao_how);
>  int libxl_device_disk_remove(libxl_ctx *ctx, uint32_t domid,
>                               libxl_device_disk *disk,
>                               const libxl_asyncop_how *ao_how); 

This means you need:
        diff -r 95cb75013da5 tools/ocaml/libs/xl/xenlight_stubs.c
        --- a/tools/ocaml/libs/xl/xenlight_stubs.c      Fri Jul 20 10:34:50 
2012 +0100
        +++ b/tools/ocaml/libs/xl/xenlight_stubs.c      Fri Jul 20 10:40:45 
2012 +0100
        @@ -247,7 +247,7 @@ value stub_xl_device_disk_add(value info
                device_disk_val(&gc, &lg, &c_info, info);
         
                INIT_CTX();
        -       ret = libxl_device_disk_add(ctx, Int_val(domid), &c_info);
        +       ret = libxl_device_disk_add(ctx, Int_val(domid), &c_info, 0);
                if (ret != 0)
                        failwith_xl("disk_add", &lg);
                FREE_CTX();
        
I also got:
        xenlight_stubs.c: In function âstub_xl_device_nic_addâ:
        xenlight_stubs.c:284: error: too few arguments to function 
âlibxl_device_nic_addâ
        xenlight_stubs.c: In function âstub_xl_device_vkb_addâ:
        xenlight_stubs.c:318: error: too few arguments to function 
âlibxl_device_vkb_addâ
        xenlight_stubs.c: In function âstub_xl_device_vkb_destroyâ:
        xenlight_stubs.c:354: error: too few arguments to function 
âlibxl_device_vkb_destroyâ
        xenlight_stubs.c: In function âstub_xl_device_vfb_addâ:
        xenlight_stubs.c:372: error: too few arguments to function 
âlibxl_device_vfb_addâ
        xenlight_stubs.c: In function âstub_xl_device_vfb_destroyâ:
        xenlight_stubs.c:408: error: too few arguments to function 
âlibxl_device_vfb_destroyâ
but I presume you can find the right patches for those without me
sending them one by one.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel