Re: [Xen-devel] [PATCH v9 08/17] libxl: convert libxl_device_disk_add to an async op

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("Re: [PATCH v9 08/17] libxl: convert 
libxl_device_disk_add to an async op"):
> Ian Jackson wrote:
> > This comment seems to be wrong ?  We set the callback
> > to device_backend_callback but perhaps that calls aodev->callback ?
> 
> Yes, device_backend_callback is the callback for the devstate event, but
> not the callback for the global aodev operation, which is stored in
> aodev->callback. I think the caller doesn't need to know that internally
> we set another callback, for the devstate event, since what matters is
> that aodev->callback will be called when the operation is finished.

Right, OK.

> >> @@ -1808,6 +1829,8 @@ struct libxl__ao_devices {
> >>   * The libxl__ao_device passed to this function should be
> >>   * prepared using libxl__prepare_ao_device prior to calling
> >>   * this function.
> >> + *
> >> + * Once finished, aodev->callback will be executed.
> >>   */
> >>  _hidden void libxl__initiate_device_remove(libxl__egc *egc,
> >>                                             libxl__ao_device *aodev);
> >> @@ -2162,6 +2185,19 @@ _hidden void libxl__destroy_domid(libxl__egc *egc,
> > 
> > Is this hunk in the wrong patch ?
> 
> Yes, it is.

Right, apart from that last thing, then:

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel