Re: [Xen-devel] [PATCH 1 of 3] xend/pvscsi: fix passing of SCSI control LUNs

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-08-23 at 19:24 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1345743306 -7200
> # Node ID 52f3d52bacdecb2c8d7f8aa26e2600febc03b6dd
> # Parent  e6ca45ca03c2e08af3a74b404166527b68fd1218
> xend/pvscsi: fix passing of SCSI control LUNs
> 
> Currently pvscsi can not pass SCSI devices that have just a scsi_generic node.
> In the following example sg3 is a control LUN for the disk sdd.
> But vscsi=['4:0:2:0,0:0:0:0'] does not work because the internal 'devname'
> variable remains None. Later writing p-devname to xenstore fails because None
> is not a valid string variable.

Just out of interest, would you not need to pass through 4:0:2:1 too?

> Since devname is used for just informational purpose use sg also as devname.
> 
> carron:~ $ lsscsi -g
> [0:0:0:0]    disk    ATA      FK0032CAAZP      HPF2  /dev/sda   /dev/sg0
> [4:0:0:0]    disk    HP       P2000G3 FC/iSCSI T100  /dev/sdb   /dev/sg1
> [4:0:1:0]    disk    HP       P2000G3 FC/iSCSI T100  /dev/sdc   /dev/sg2
> [4:0:2:0]    storage HP       HSV400           0950  -         /dev/sg3
> [4:0:2:1]    disk    HP       HSV400           0950  /dev/sdd   /dev/sg4
> [4:0:3:0]    storage HP       HSV400           0950  -         /dev/sg5
> [4:0:3:1]    disk    HP       HSV400           0950  /dev/sde   /dev/sg6
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> diff -r e6ca45ca03c2 -r 52f3d52bacde tools/python/xen/util/vscsi_util.py
> --- a/tools/python/xen/util/vscsi_util.py
> +++ b/tools/python/xen/util/vscsi_util.py
> @@ -105,6 +105,8 @@ def _vscsi_get_scsidevices_by_lsscsi(opt
>              devname = None
>          try:
>              sg = s[-1].split('/dev/')[1]
> +            if devname is None:
> +                devname = sg
>              scsi_id = _vscsi_get_scsiid(sg)
>          except IndexError:
>              sg = None
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel