Re: [Xen-devel] [PATCH 2 of 3] xend/pvscsi: fix usage of persistant device names for SCSI devices

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-08-23 at 19:24 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1345743313 -7200
> # Node ID 2b9992aea26cfebc2dda56d1a97a35dc3a5c8ce8
> # Parent  52f3d52bacdecb2c8d7f8aa26e2600febc03b6dd
> xend/pvscsi: fix usage of persistant device names for SCSI devices
> 
> Currently the callers of vscsi_get_scsidevices() do not pass a mask
> string.  This will call "lsscsi -g '[]'", which causes a lsscsi syntax
> error. As a result the sysfs parser _vscsi_get_scsidevices() is used.
> But this parser is broken and the specified names in the config file are
> not found.
> 
> Using a mask '*' if no mask was given will call lsscsi correctly and the
> following config is parsed correctly:
> 
> vscsi=[
>       '/dev/sg3, 0:0:0:0',
>       '/dev/disk/by-id/wwn-0x600508b4000cf1c30000800000410000, 0:0:0:1'
> ]
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> diff -r 52f3d52bacde -r 2b9992aea26c tools/python/xen/util/vscsi_util.py
> --- a/tools/python/xen/util/vscsi_util.py
> +++ b/tools/python/xen/util/vscsi_util.py
> @@ -150,7 +150,7 @@ def _vscsi_get_scsidevices_by_sysfs():
>      return devices
>  
> 
> -def vscsi_get_scsidevices(mask=""):
> +def vscsi_get_scsidevices(mask="*"):
>      """ get all scsi devices information """
>  
>      devices = _vscsi_get_scsidevices_by_lsscsi("[%s]" % mask)
> @@ -279,7 +279,7 @@ def get_scsi_device(pHCTL):
>              return _make_scsi_record(scsi_info)
>      return None
>  
> -def get_all_scsi_devices(mask=""):
> +def get_all_scsi_devices(mask="*"):

This one could be = None , but I don't think it matters much.

>      scsi_records = []
>      for scsi_info in vscsi_get_scsidevices(mask):
>          scsi_record = _make_scsi_record(scsi_info)
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel