Re: [Xen-devel] [PATCH mini-os enhancements for vtpm 4/8] disable mfn_is_ram

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-09-17 at 23:13 +0100, Samuel Thibault wrote:
> Matthew Fioravante, le Mon 17 Sep 2012 17:58:31 -0400, a écrit :
> > This patch disables the mfn_is_ram check in mini-os. The current check
> > is insufficient and fails on some systems with larger than 4gb memory.

How does it fail? What are the symptoms? What are the inputs to this
function which cause it to fail?

> And it is only used for checks, not for actual decisions.

It's made completely useless here though, why not either fix it or
remove it altogether?

There's certainly no reason to leave the dead code after the return
statement.

> 
> Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> 
> Samuel
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel