Re: [Xen-devel] [PATCH mini-os enhancements for vtpm 4/8] disable mfn_is_ram

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Ian Campbell, le Tue 18 Sep 2012 08:30:50 +0100, a écrit :
> On Mon, 2012-09-17 at 23:13 +0100, Samuel Thibault wrote:
> > Matthew Fioravante, le Mon 17 Sep 2012 17:58:31 -0400, a écrit :
> > > This patch disables the mfn_is_ram check in mini-os. The current check
> > > is insufficient and fails on some systems with larger than 4gb memory.
> 
> How does it fail?

When there is more than 4gb memory, there is IO memory between e.g. 3gb
and 4gb, which will be considered as RAM.

> > And it is only used for checks, not for actual decisions.
> 
> It's made completely useless here though, why not either fix it or
> remove it altogether?

We can probably just remove the check in __do_ioremap, which AFAIK is
the only call.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel