Re: [Xen-devel] [PATCH vtpm_manager 2/2] Fixes to vtpm hotplug scripts

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-09-17 at 22:19 +0100, Matthew Fioravante wrote:
> This patch fixes IO deadlocks in the vtpm hotplug scripts

Is the switch from awk to gawk a part of this? How?

IIRC we deliberately switched from using gawk specific features to allow
e.g. mawk to be used. If there is some gawk specific construct used here
it would be better to recast it in more portable terms IMHO.

> - set -e
> + local resp_hex
> + #send cmd to vtpm_manager and get response
> + if ! resp_hex=`echo "$cmd$(str_to_hex32 $inst)" | vtpmmgrtalk `; then

Is this really the command/control interface provided by VTPM? Can we
not work with upstream to define something more usable?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel