Re: [Xen-devel] [PATCH v1 2/8]: PVH mmu changes

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index 6a198e4..6c5ad83 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -24,9 +24,19 @@ int xen_create_contiguous_region(unsigned long vstart, 
> unsigned int order,
>  void xen_destroy_contiguous_region(unsigned long vstart, unsigned int order);
>  
>  struct vm_area_struct;
> +struct xen_pvh_pfn_info;

If you move the struct def'n up you don't need this forward decl.

>  int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
>                              unsigned long addr,
>                              unsigned long mfn, int nr,
> -                            pgprot_t prot, unsigned domid);
> +                            pgprot_t prot, unsigned domid,
> +                            struct xen_pvh_pfn_info *pvhp);
> +int xen_unmap_domain_mfn_range(struct vm_area_struct *vma,
> +                            struct xen_pvh_pfn_info *pvhp);
> +
> +struct xen_pvh_pfn_info {

Can we call this xen_remap_mfn_info or something? PVH is x86 specific
while this struct is also useful on ARM.

> +     struct page **pi_paga;          /* pfn info page array */

can we just call this "pages"? paga is pretty meaningless.

> +     int           pi_num_pgs;
> +     int           pi_next_todo;

I don't think we need the pi_ prefix for any of these.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel