Re: [Xen-devel] [PATCH v1 2/8]: PVH mmu changes

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Wed, 3 Oct 2012 16:42:43 +0100
Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

> 
> > diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> > index 6a198e4..6c5ad83 100644
> > --- a/include/xen/xen-ops.h
> > +++ b/include/xen/xen-ops.h
> > @@ -24,9 +24,19 @@ int xen_create_contiguous_region(unsigned long
> > vstart, unsigned int order, void
> > xen_destroy_contiguous_region(unsigned long vstart, unsigned int
> > order); struct vm_area_struct;
> > +struct xen_pvh_pfn_info;
> 
> If you move the struct def'n up you don't need this forward decl.
> 
> >  int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
> >                            unsigned long addr,
> >                            unsigned long mfn, int nr,
> > -                          pgprot_t prot, unsigned domid);
> > +                          pgprot_t prot, unsigned domid,
> > +                          struct xen_pvh_pfn_info *pvhp);
> > +int xen_unmap_domain_mfn_range(struct vm_area_struct *vma,
> > +                          struct xen_pvh_pfn_info *pvhp);
> > +
> > +struct xen_pvh_pfn_info {
> 
> Can we call this xen_remap_mfn_info or something? PVH is x86 specific
> while this struct is also useful on ARM.

I already renamed it to: xen_xlat_pfn_info.

> > +   struct page **pi_paga;          /* pfn info page
> > array */
> 
> can we just call this "pages"? paga is pretty meaningless.

page array! i can rename page_array or page_a.


> > +   int           pi_num_pgs;
> > +   int           pi_next_todo;
> 
> I don't think we need the pi_ prefix for any of these.

The prefix for fields in struct make it easy to find via cscope or
grep, otherwise, it's a nightmare to find common field names like
pages when reading code. I really get frustrated. I prefer prefixing
all field names.

thanks
Mukesh




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel