Re: [Xen-devel] [PATCH] docs: check for documentation generation tools in docs/configure.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-12-07 at 09:35 +0000, Roger Pau Monne wrote:
> On 06/12/12 12:06, Ian Campbell wrote:
> > diff --git a/config/Docs.mk.in b/config/Docs.mk.in
> > new file mode 100644
> > index 0000000..b6ab6fe
> > --- /dev/null
> > +++ b/config/Docs.mk.in
> > @@ -0,0 +1,20 @@
> > +# Prefix and install folder
> > +prefix              := @prefix@
> > +PREFIX              := $(prefix)
> > +exec_prefix         := @exec_prefix@
> > +libdir              := @libdir@
> > +LIBDIR              := $(libdir)
> > +
> > +# Tools
> > +PS2PDF              := @PS2PDF@
> > +DVIPS               := @DVIPS@
> > +LATEX               := @LATEX@
> > +FIG2DEV             := @FIG2DEV@
> > +LATEX2HTML          := @LATEX2HTML@
> 
> Didn't we drop all the Latex stuff from Docs? I've did a quick grep and
> it seems it's still used by xen-api related docs... What I cannot find
> is any user for LATEX2HTML, can't we remove than one?

Seems like we can, yes. Probably this was still used when Matt wrote the
original patch.

> 
> > @@ -26,10 +26,12 @@ all: build
> >
> >  .PHONY: build
> >  build: html txt man-pages figs
> > -   @if which $(DOT) 1>/dev/null 2>/dev/null ; then              \
> > -   $(MAKE) -C xen-api build ; else                              \
> > -        echo "Graphviz (dot) not installed; skipping xen-api." ; fi
> > +ifdef DOT
> > +   $(MAKE) -C xen-api build
> >     rm -f *.aux *.dvi *.bbl *.blg *.glo *.idx *.ilg *.log *.ind *.toc
> > +else
> > +   @echo "Graphviz (dot) not installed; skipping xen-api."
> > +endif
> 
> Don't we need the latex stuff to build xen-api docs? For the xen-api
> Makefile to succeed we seem to need PS2PDF, LATEX, DOT, DVIPS and NEATO.

Given that this "xen-api" doc documents an old unmaintained version of
the XenAPI, which bears little to no relation to what is implemented in
xapi and which is only partially implemented in xend (which is
deprecated) I'm leaning strongly towards just nuking this particular
document from unstable. Anyone who is interested can just use the
version which was in 4.2...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel