Re: [Xen-devel] [xen-4.1-testing test] 14762: regressions - FAIL

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-12-17 at 04:24 +0000, xen.org wrote:
> flight 14762 xen-4.1-testing real [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/14762/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-amd64-i386-qemut-rhel6hvm-amd 11 leak-check/check    fail REGR. vs. 
> 14679
>  test-amd64-amd64-xl          18 leak-check/check          fail REGR. vs. 
> 14679
>  test-amd64-i386-rhel6hvm-intel 11 leak-check/check        fail REGR. vs. 
> 14679
>  test-amd64-i386-xl           18 leak-check/check          fail REGR. vs. 
> 14679
>  test-i386-i386-xl            18 leak-check/check          fail REGR. vs. 
> 14679
>  test-amd64-i386-xl-credit2   18 leak-check/check          fail REGR. vs. 
> 14679
>  test-amd64-i386-rhel6hvm-amd 11 leak-check/check          fail REGR. vs. 
> 14679
>  test-amd64-i386-qemuu-rhel6hvm-amd 11 leak-check/check    fail REGR. vs. 
> 14679
>  test-amd64-i386-xl-multivcpu 18 leak-check/check          fail REGR. vs. 
> 14679
>  test-amd64-i386-qemut-rhel6hvm-intel 11 leak-check/check  fail REGR. vs. 
> 14679
>  test-amd64-i386-qemuu-rhel6hvm-intel 11 leak-check/check  fail REGR. vs. 
> 14679
[...]

http://www.chiark.greenend.org.uk/~xensrcts/logs/14706/test-amd64-amd64-xl/18.ts-leak-check.log
shows a load of leaked xenstore paths relating to the console. The
bisector has fingered the first one (23428:93e17b0cd035) as having
caused it.

Given that we are at 4.1.4-rc2 unless we can fix this today (or by
tomorrow) we should revert. Possibly we should even just revert and try
again for 4.1.5.

Perhaps we should leave the both the libxl__device_destroy_tapdisk and
xs_rm in libxl__device_destroy? The xs_rm is harmless in the case where 
libxl__device_destroy_tapdisk has done something and useful when it has
not.

The call to libxl__device_destroy_tapdisk in libxl__devices_destroy from
the second patch also looks entirely to me -- the function loops over
devices and yet calls that function only only for the last one (which
happens to be a console). I think this is a mismerge on the backport 
23427:255a0b6a8104 (to unstable) makes this change to
libxl__device_destroy with very similar context to the change to
libxl__devices_destroy in 23427:255a0b6a8104 (to 4.1-testing).

Ian.

> ------------------------------------------------------------
> changeset:   23428:93e17b0cd035
> tag:         tip
> user:        Greg Wettstein <greg@xxxxxxxxxxxx>
> date:        Thu Dec 13 14:35:58 2012 +0000
> 
>     libxl: avoid blktap2 deadlock on cleanup
> 
>     Establishes correct cleanup behavior for blktap devices.  This patch
>     implements the release of the backend device before calling for
>     the destruction of the userspace component of the blktap device.
> 
>     Without this patch the kernel xen-blkback driver deadlocks with
>     the blktap2 user control plane until the IPC channel is terminated by the
>     timeout on the select() call.  This results in a noticeable delay
>     in the termination of the guest and causes the blktap minor
>     number which had been allocated to be orphaned.
> 
>     Signed-off-by: Greg Wettstein <greg@xxxxxxxxxxxx>
>     Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>     Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>     Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> 
> changeset:   23427:255a0b6a8104
> user:        Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> date:        Wed Dec 12 17:41:15 2012 +0000
> 
>     From: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
>     libxl: attempt to cleanup tapdisk processes on disk backend destroy.
> 
>     This patch properly terminates the tapdisk2 process(es) started
>     to service a virtual block device.
> 
>     Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>     Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
>     xen-unstable changeset: 23883:7998217630e2
>     xen-unstable date: Wed Sep 28 16:42:11 2011 +0100
>     Signed-off-by: Greg Wettstein <greg@xxxxxxxxxxxx>
>     Backport-requested-by: Greg Wettstein <greg@xxxxxxxxxxxx>
>     Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> 
> (qemu changes not included)
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel