[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [V2] xen-netback notify DomU to send ARP.



ä 2013å01æ21æ 19:55, Jan Beulich åé:
On 21.01.13 at 08:26, jianhai luan <jianhai.luan@xxxxxxxxxx> wrote:
+static void notify_front_arping(struct xenbus_device *dev)
+{
+       int err;
+
+       if (dev->state != XenbusStateConnected)
+               return;
+
+       err = xenbus_printf(XBT_NIL, dev->nodename, "state", "%d", dev->state);
+       if (err) {
+               pr_fmt("Error writing the state");
What's this? pr_fmt() alone makes no sense at all, and I'd be
pretty surprised if the compiler didn't warn about this construct.

Further, you probably want to say "re-writing" and include the
error code in the message. And of course you want a \n at the
end.

Finally - no need for the braces ...

+       }
+
+       return;
... nor this "return".

+}

Sorry for above details, and thank you for notifying.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Thanks,
Jason

Attachment: 0001-xen-netback-notify-frontend-to-send-gratuitous-ARP.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.