Re: [Xen-devel] [PATCH] vtpmmgr: fix build on 32-bit

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-01-21 at 15:08 +0000, Fioravante, Matthew E. wrote:
> > > The idea was to keep vtpm and vtpmmgr as small as possible. Only the
> > > components of polarssl that are required are linked in. Polarssl is
> > > designed so that you can mix and match the specific crypto pieces by
> > > choosing specific .o files. Some parts of polarssl like networking may
> > > even require lwip or other depencies which vtpm does not use.
> > 
> > Because you are linking the .a file the linker should only pull in the bits 
> > you
> > actually use, and by extension only pull in their dependencies.
> 
> In that case if the output binaries are the same we can change it to
> link to the entire library if that is what's preferred.

The sizes are identical, I didn't check the actual contents.

I'm a bit more concerned about the first patch ("vtpmmgr: fix build on
32-bit") right at the moment since the build failure is blocking the
automated test. If you are ok with please could you ack.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel