Re: [Xen-devel] [PATCH] tools: revert to using /var and /etc/

[Sander Eikelenboom <linux@xxxxxxxxxxxxxx>]

Monday, January 28, 2013, 5:49:28 PM, you wrote:

> On Mon, 28 Jan 2013, Ian Campbell wrote:
>> On Mon, 2013-01-28 at 10:39 +0000, Sander Eikelenboom wrote:
>> > Another thing is that:
>> >         $QEMU_XEN -xen-domid 0 -xen-attach -name dom0 -nographic -M
>> > xenpv -daemonize -monitor /dev/null -pidfile $QEMU_PIDFILE
>> > 
>> > Doesn't seem to start with upstream qemu, combination of -nographic
>> > and -daemonize doesn't seem to be allowed anymore.
>> > (not a problem for me, because i don't seem to be using it as
>> > diskbackend, but for a 4.3 release ...) 
>> 
>> Stefano, is this expected?
>  
> No, it is not. Sander, thanks for the report.
> This is the reason:

> /* According to documentation and historically, -nographic redirects
>  * serial port, parallel port and monitor to stdio, which does not work
>  * with -daemonize.  We can redirect these to null instead, but since
>  * -nographic is legacy, let's just error out.
>  * We disallow -nographic only if all other ports are not redirected
>  * explicitly, to not break existing legacy setups which uses
>  * -nographic _and_ redirects all ports explicitly - this is valid
>  * usage, -nographic is just a no-op in this case.
>  */

> If fact it looks like that the appended patch fixes it, can you please
> confirm it?

Confirmed thx !

--
Sander

> ---

> diff --git a/tools/hotplug/Linux/init.d/xencommons 
> b/tools/hotplug/Linux/init.d/xencommons
> index cc8177e..dc40425 100644
> --- a/tools/hotplug/Linux/init.d/xencommons
> +++ b/tools/hotplug/Linux/init.d/xencommons
> @@ -116,7 +116,7 @@ do_start () {
>         test "`uname`" != "NetBSD" || xenbackendd $XENBACKENDD_ARGS
>         echo Starting QEMU as disk backend for dom0
>         test -z "$QEMU_XEN" && QEMU_XEN=/usr/lib/xen/bin/qemu-system-i386
> -       $QEMU_XEN -xen-domid 0 -xen-attach -name dom0 -nographic -M xenpv 
> -daemonize -monitor /dev/null
> +       $QEMU_XEN -xen-domid 0 -xen-attach -name dom0 -nographic -M xenpv 
> -daemonize -monitor /dev/null -serial /dev/null -parallel /dev/null
>  }
>  do_stop () {
>          echo Stopping xenconsoled



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel