Re: [Xen-devel] [xen-unstable test] 16231: regressions - FAIL

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.02.13 at 10:06, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> This patch fixes the current build breakage, anyone want to ack or nack?

Looks almost fine to me, but probably one of the other ARM guys
would want to ack this anyway.

>> --- a/tools/include/xen-foreign/mkheader.py
>> +++ b/tools/include/xen-foreign/mkheader.py
>> @@ -20,15 +20,18 @@ footer = {};
>>  inttypes["arm32"] = {
>>      "unsigned long" : "uint32_t",
>>      "long"          : "uint32_t",
>> -    "xen_pfn_t"     : "uint64_t",
>> -    "xen_ulong_t"   : "uint64_t",
>> +    "xen_pfn_t"     : "__align8__ uint64_t",
>> +    "xen_ulong_t"   : "__align8__ uint64_t",
>> +    "uint64_t"      : "__align8__ uint64_t",
>>  };
>>  header["arm32"] = """
>>  #define __arm___ARM32 1
>>  #if defined(__GNUC__) && !defined(__STRICT_ANSI__)
>>  # define __DECL_REG(n64, n32) union { uint64_t n64; uint32_t n32; }
>> +# define __align8__ __attribute__((aligned (8)))

Using __aligned__ here would probably be a tiny bit more safe (I
do realize that x86-64 already uses the same construct you use).

>>  #else
>>  # define __DECL_REG(n64, n32) uint64_t n64
>> +# define FIXME

Did you mean

# define __align8__ FIXME

(also further down)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel